fix: add support for untyped snowflake arrays#2608
Merged
Conversation
tobymao
reviewed
May 14, 2024
| ) | ||
| if new_type.this == current_type.this == exp.DataType.Type.ARRAY: | ||
| # Some engines (i.e. Snowflake) don't support defining types on arrays | ||
| if not new_type.expressions or not current_type.expressions: |
Contributor
There was a problem hiding this comment.
what if something is untyped and then it becomes typed?
Collaborator
Author
There was a problem hiding this comment.
There is no known way to do this today. The only untyped example must remain untyped.
tobymao
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change the schema differ assumed all arrays had a type which isn't true for Snowflake. This adds proper support for "untyped" arrays.
Also did some cleanup where old
selfreferenced weren't renamed when methods were changed to classmethods.