Fix: Parsing of session properties when only one key-value pair is provided#2610
Merged
izeigerman merged 1 commit intomainfrom May 14, 2024
Merged
Fix: Parsing of session properties when only one key-value pair is provided#2610izeigerman merged 1 commit intomainfrom
izeigerman merged 1 commit intomainfrom
Conversation
eakmanrq
approved these changes
May 14, 2024
tobymao
reviewed
May 14, 2024
| session_properties = {k: exp.Literal.string(k).eq(v) for k, v in provided.items()} | ||
| elif provided: | ||
| if isinstance(provided, exp.Paren): | ||
| provided = exp.Tuple(expressions=[provided.this]) |
Contributor
There was a problem hiding this comment.
provided.this.unnest()
then you can handle many parenthesis lol
tobymao
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expression
is being parsed into the
exp.Parenexpression instead ofexp.Tuplewhich was not accounted for while merging the model's values with the default ones.