Chore: pass dialect in builders used within sushi python models#2629
Merged
georgesittas merged 2 commits intomainfrom May 17, 2024
Merged
Chore: pass dialect in builders used within sushi python models#2629georgesittas merged 2 commits intomainfrom
georgesittas merged 2 commits intomainfrom
Conversation
georgesittas
force-pushed
the
jo/fix_sushi_bq
branch
from
d529a91 to
84f09ea
Compare
tobymao
approved these changes
May 17, 2024
crericha
reviewed
May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, the
from_builder would produce aParseErrorwhen run against specific engines. The bug was spotted for BigQuery, because we'd pass a backtick-quoted name in the builder, which can't be parsed by the sqlglot base dialect.