Feat: add support for CSV input data loading from file or inline#2640
Feat: add support for CSV input data loading from file or inline#2640
Conversation
georgesittas
left a comment
There was a problem hiding this comment.
Cool, looks good. Some general comments to keep in mind w.r.t. code style & conventions. The direction here is good, let's add some tests.
|
@Themiscodes let's make sure to test The problem is that |
I agree that the latter option seems better. Currently empty columns are handled similar to the yaml and are set to |
d91f17b to
029c79a
Compare
georgesittas
left a comment
There was a problem hiding this comment.
@Themiscodes thanks for addressing comments, did another pass on this. Comments are mostly about refactoring the unit tests.
Let's also test 1) specifying paths (both csv, yaml) - look into tmp_path etc in other tests 2) doing format: yaml and then supplying the rows like we usually do (rows: ...), 3) supplying a path without a format (expected is to load yaml) 4) supplying a format that is not supported
de930df to
6f069ae
Compare
|
@georgesittas addressed your comments
Also removed unnecessary tests as per your suggestions and parametrized dictionaries where possible. |
87adebc to
bd4d8cb
Compare
This is WIP. Feedback is welcome.
EDIT (George):
This addresses the last item in #1637!