Fix: Only check destructive changes for directly modified models at plan time#2733
Merged
izeigerman merged 1 commit intomainfrom Jun 4, 2024
Merged
Conversation
tobymao
approved these changes
Jun 4, 2024
izeigerman
deleted the
fix-destructive-directly-modified-only-at-plan-time
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, we risk generating too much noise due to false positive checks for indirectly modified models whose parents have been destructively changed.
With this change, we decide to act optimistically at plan time due to the absence of complete information, and let this check fail at runtime if necessary.