Fix: Shortcuts and some styling for editor#2783
Merged
Conversation
vchan
reviewed
Jun 20, 2024
| if (isNotNil(completionResult)) { | ||
| const options = completionResult.options ?? [] | ||
| completionResult.options = options.concat(suggestions) | ||
| completionResult.map = () => null // Updates sussgestions to switch between lower and upper case |
Contributor
There was a problem hiding this comment.
Suggested change
| completionResult.map = () => null // Updates sussgestions to switch between lower and upper case | |
| completionResult.map = () => null // Updates suggestions to switch between lower and upper case |
| const state = editorView.state | ||
| const text = state.doc.toString() | ||
|
|
||
| if (text === content || isNil(diffChars)) return |
Contributor
There was a problem hiding this comment.
What's the relationship between text and content?
Contributor
Author
There was a problem hiding this comment.
text - is current editor's content, I'll rename
caiters
approved these changes
Jun 20, 2024
Contributor
caiters
left a comment
caiters
left a comment
There was a problem hiding this comment.
cursor fix works super well, nice job
vchan
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix jumping cursor when user typing
Run custom query on Cmd + Enter
Show suggestion in uppercase in user typing in uppercase