Skip to content

Chore!: bump sqlglot to v25.20.1#3100

Merged
georgesittas merged 2 commits intomainfrom
jo/bump_sqlglot_to_v25_20_1
Sep 6, 2024
Merged

Chore!: bump sqlglot to v25.20.1#3100
georgesittas merged 2 commits intomainfrom
jo/bump_sqlglot_to_v25_20_1

Conversation

@georgesittas
Copy link
Contributor

@georgesittas georgesittas commented Sep 6, 2024 •
edited
Loading

Changed some type hints due to the following errors I encountered while iterating locally:

sqlmesh/core/constants.py:44: error: Module has no attribute "sched_getaffinity"  [attr-defined]
sqlmesh/integrations/github/cicd/controller.py:698: error: Argument "result" to "conclusion_handler" has incompatible type "TestResult | None"; expected "TestResult"  [arg-type]
sqlmesh/integrations/github/cicd/controller.py:698: error: Argument "output" to "conclusion_handler" has incompatible type "str | None"; expected "str"  [arg-type]

@georgesittas georgesittas requested a review from tobymao September 6, 2024 13:22
@georgesittas georgesittas merged commit fd3a2d1 into main Sep 6, 2024
@georgesittas georgesittas deleted the jo/bump_sqlglot_to_v25_20_1 branch September 6, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobymao tobymao tobymao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@georgesittas @tobymao