Skip to content

Fix(bigquery): materialized views do not support column comments#3166

Merged
treysp merged 1 commit intomainfrom
trey/bq-mat-view-comments
Sep 27, 2024
Merged

Fix(bigquery): materialized views do not support column comments#3166
treysp merged 1 commit intomainfrom
trey/bq-mat-view-comments

Conversation

@treysp
Copy link
Contributor

@treysp treysp commented Sep 23, 2024

@treysp treysp force-pushed the trey/bq-mat-view-comments branch from 53f2c90 to 7665ef2 Compare September 24, 2024 15:16
Copy link
Contributor

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even though some of the complexity surfaced elsewhere (i.e. new kwarg), I prefer this over having an enum flag which is mostly unused. Let's see what others think.

@treysp treysp force-pushed the trey/bq-mat-view-comments branch from 7665ef2 to abedafe Compare September 27, 2024 14:24
@treysp treysp enabled auto-merge (squash) September 27, 2024 14:25
@treysp treysp merged commit bacea87 into main Sep 27, 2024
@treysp treysp deleted the trey/bq-mat-view-comments branch September 27, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQLMesh fails to create a materialized views in BigQuery when registering comments

3 participants