feat!: bot commands that run a single step raise on failure#3195
Merged
feat!: bot commands that run a single step raise on failure#3195
Conversation
tobymao
approved these changes
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most users use the
run-allbot command which runs several steps at once. Since it runs several steps it only fails if the execution of those steps fails. To understand which of those steps failed then you would check the bot output. This makes it easy to differentiate all the different types of failures.This feels less intuitive when running a single step. Since there aren't sub-steps then having the only step that ran fail and not having the bot itself fail feels less intuitive. This might feel ok when running something like "Check Required Approvers" or "Run Tests" but less intuitive when running "Deploy to Prod".
Therefore this PR keeps the run-all behavior the same, which we haven't received any feedback on, but then makes all the individual steps fail if the step itself fails. Some other options: