Feat: Add support for YC managed Airflow#3396
Conversation
|
It appears that the only difference from the vanilla It's fine if we still want a custom configuration for YC, but its implementation should become much simpler: Also does it need both the token and username / password? |
|
Yes, both the token and username:password are required, as stated in the documentation: https://yandex.cloud/en/docs/managed-airflow/operations/af-interfaces#rest-api. This is the primary reason I prefer to implement it as a separate class, rather than modifying the vanilla |
|
@petrikoro any chance you can add a section on YC AIrflow support to https://github.com/TobikoData/sqlmesh/blob/main/docs/integrations/airflow.md? |
Updated docs, could you please take a look? |
docs/integrations/airflow.md
Outdated
|
|
||
| ### Yandex Cloud | ||
|
|
||
| Yandex Cloud offers [managed Airflow instances](https://yandex.cloud/en/services/managed-airflow), and SQLMesh fully supports Airflow hosted by Yandex Cloud. |
There was a problem hiding this comment.
Sorry about the back and forth but it'd be helpful to mention which scheduler type to specify to use this. Eg. here's how we document this for the Cloud Composer: https://github.com/TobikoData/sqlmesh/blob/13cf28ab60972ef043fbe6c65ddc11908f949631/docs/reference/configuration.md#cloud-composer. We can then include a link to the config reference here.
There was a problem hiding this comment.
Thank you! Somehow I missed the part about the configuration :D
I added information about the configuration in the latest commit and slightly adjusted the wording in docs/integrations/airflow.md
|
One last comment, should be good to go otherwise. |
|
Thanks a lot for addressing comments! |
Add Support for YC Managed Airflow
Description
This PR introduces a new configuration for YC Managed Airflow, enabling the use of both
username:passwordcredentials and an IAM token for authentication.Documentation for the YC Managed Airflow: https://yandex.cloud/en/docs/managed-airflow/operations/af-interfaces
Changes Made
YCAirflowSchedulerConfigclass to support YC Managed Airflow configuration.