Feat: update CLI plan command's create environment message#3397
Merged
Feat: update CLI plan command's create environment message#3397
Conversation
cad6cae to
cd82e47
Compare
sungchun12
reviewed
Nov 19, 2024
f5e829f to
05b1083
Compare
izeigerman
reviewed
Nov 21, 2024
4fc6a4a to
97e3ed3
Compare
a632ca2 to
54f31d4
Compare
izeigerman
reviewed
Nov 23, 2024
izeigerman
reviewed
Nov 23, 2024
Contributor
georgesittas
left a comment
There was a problem hiding this comment.
A couple of suggestions and a question. Feel free to ignore the suggestions if there's already alignment on the messaging.
Great work 👍
e752489 to
40719ec
Compare
b4ac75a to
06b471a
Compare
06b471a to
7f484c6
Compare
izeigerman
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sqlmesh plancommand's output includes a message about creating environments.The message can be confusing, so this PR updates it to be consistent and clear.
For different
planscenarios, the old and new messages are:Create prod env
New environment
prodwill be created fromprodSummary of differences against
prod:prodenvironment will be initializedCreate dev env without first creating prod
New environment
devwill be created fromprodSummary of differences against
dev:devenvironment will be initializedNew env with changes
New environment
devwill be created fromprodSummary of differences against
dev:New environment
devwill be created fromprodDifferences from the
prodenvironment:Existing env with changes
Summary of differences against
dev:Differences from the
devenvironment:Plan with no changes (existing environment)
No differences when compared to
prodNo changes to plan: project files match the
prodenvironmentPlan with no changes (new environment)
Error: No changes were detected. Make a change or run with --include-unmodified to create a new environment without changes.
Error: Creating a new environment requires a change, but project files match the
prodenvironment. Make a change or use the --include-unmodified flag to create a new environment without changes.Plan with --create-from environment that doesn't exist
New environment
devwill be created fromdoesnotexistSummary of differences against
dev:WARNING - The environment name 'doesnotexist' was passed to the
plancommand's--create-fromargument, but 'doesnotexist' does not exist. Initializing new environment 'dev' from scratch.devenvironment will be initialized