Fix!: use string func in surrogate key macro (only md5 at the moment)#3448
Merged
georgesittas merged 1 commit intomainfrom Dec 3, 2024
Merged
Fix!: use string func in surrogate key macro (only md5 at the moment)#3448georgesittas merged 1 commit intomainfrom
georgesittas merged 1 commit intomainfrom
Conversation
tobymao
approved these changes
Dec 2, 2024
georgesittas
force-pushed
the
jo/surrogate_key_fixes
branch
from
843c05f to
3e8029f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dialectargument in theexp.funccall can lead to incorrect AST generation. For instance, prior to this PR we'd generateMD5in BigQuery, which returns aBYTESvalue.The long term plan for improving this macro is to properly support other hash functions is to add them in SQLGlot (e.g.
SHA256Digest). I omitted this change because we can do it incrementally, fixing MD5 is higher ROI.