Skip to content

fix!: make signals serializable#3480

Merged
tobymao merged 1 commit intomainfrom
toby/signals
Dec 10, 2024
Merged

fix!: make signals serializable#3480
tobymao merged 1 commit intomainfrom
toby/signals

Conversation

@tobymao
Copy link
Contributor

@tobymao tobymao commented Dec 6, 2024

No description provided.

@tobymao
Copy link
Contributor Author

tobymao commented Dec 6, 2024

todo: migration and making sure variables are handled

@tobymao tobymao force-pushed the toby/signals branch 4 times, most recently from 9a8c8c5 to e7d3867 Compare December 6, 2024 17:40
@izeigerman
Copy link
Collaborator

@tobymao tobymao force-pushed the toby/signals branch 2 times, most recently from 9ec9c2f to 2bc2d43 Compare December 7, 2024 03:45
@tobymao tobymao force-pushed the toby/signals branch 5 times, most recently from 38792c3 to a4b4d23 Compare December 10, 2024 05:02
@tobymao tobymao merged commit 7e42ea3 into main Dec 10, 2024
@tobymao tobymao deleted the toby/signals branch December 10, 2024 17:48
Copy link
Contributor

@plaflamme plaflamme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

kind FULL,
signals [
(threshold = 0.5), # specify threshold value
random_signal(threshold = 0.5), # specify threshold value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
random_signal(threshold = 0.5), # specify threshold value
random_signal(threshold := 0.5), # specify threshold value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants