Fix: quote the table produced by _resolve_table#3494
Merged
georgesittas merged 2 commits intomainfrom Dec 10, 2024
Merged
Conversation
georgesittas
force-pushed
the
jo/fix_resolve_table
branch
2 times, most recently
from
a39093f to
f445e3d
Compare
izeigerman
reviewed
Dec 10, 2024
izeigerman
approved these changes
Dec 10, 2024
georgesittas
force-pushed
the
jo/fix_resolve_table
branch
from
f445e3d to
5c05c4d
Compare
georgesittas
force-pushed
the
jo/fix_resolve_table
branch
from
5c05c4d to
821230c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the recent refactor, where
this_modelchanged from astrinto aTableinstance, I missed the fact that we were previously quoting it, so I didn't match that behavior.We discovered that this led to an issue where the resolved table for
this_modelwould be normalized twice, if e.g. it was interpolated in a string, and hence generated as a table with unquoted identifiers.This PR fixes the above issue by having
_resolve_tablequote the table after resolving it, to match the semantics of_resolve_tables.