Feat!: Support 'optimize' flag in model defs#3512
Merged
Conversation
tobymao
reviewed
Dec 13, 2024
VaggelisD
force-pushed
the
vaggelisd/model_opt
branch
2 times, most recently
from
0e2d29e to
b38fd24
Compare
VaggelisD
force-pushed
the
vaggelisd/model_opt
branch
3 times, most recently
from
429e5fe to
6df819d
Compare
georgesittas
approved these changes
Dec 16, 2024
Contributor
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Let's test this end-to-end as well, i.e. the whole plan-apply flow.
tobymao
reviewed
Dec 16, 2024
VaggelisD
force-pushed
the
vaggelisd/model_opt
branch
from
df62256 to
0344cf0
Compare
georgesittas
approved these changes
Dec 16, 2024
Contributor
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
This needs to be marked as breaking because a migration's gonna be needed.
VaggelisD
changed the title
izeigerman
reviewed
Dec 16, 2024
izeigerman
reviewed
Dec 16, 2024
VaggelisD
force-pushed
the
vaggelisd/model_opt
branch
from
fb1e91c to
7e88c53
Compare
VaggelisD
force-pushed
the
vaggelisd/model_opt
branch
from
7e88c53 to
9111680
Compare
georgesittas
approved these changes
Dec 17, 2024
tobymao
approved these changes
Dec 18, 2024
izeigerman
reviewed
Dec 18, 2024
Co-authored-by: Iaroslav Zeigerman <zeigerman.ia@gmail.com>
VaggelisD
force-pushed
the
vaggelisd/model_opt
branch
from
07b9942 to
30f5360
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3479