Feat: improve message when no models are ready to run#3513
Merged
izeigerman merged 5 commits intomainfrom Dec 20, 2024
Merged
Conversation
Contributor
|
Love the formatting of the message. I bet some users will want the ability to configure the local timezone, but not needed for this PR. |
izeigerman
reviewed
Dec 16, 2024
3dd4b05 to
a9b5650
Compare
izeigerman
reviewed
Dec 19, 2024
izeigerman
reviewed
Dec 19, 2024
91a982f to
d5a5339
Compare
d5a5339 to
8634d3a
Compare
georgesittas
approved these changes
Dec 20, 2024
izeigerman
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the message displayed when the
sqlmesh runcommand is executed but no models are ready to run.The new message includes the time when the next model will be ready to run in UTC and local timezone.
Old output
New output
Implementation details:
success/failure/nothing to dointerval_unit.cron_next(now())