Skip to content

Fix: Adapt evaluator test to use unique model names #3538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
themisvaltinos merged 1 commit into from
Dec 19, 2024
Merged

Fix: Adapt evaluator test to use unique model names #3538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/core/test_snapshot_evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3375,7 +3375,7 @@ def validate_engine_call(
return None

@model(
"db.test_model",
"db.multi_engine_test_model",
kind="full",
gateway="secondary",
columns={"id": "string", "name": "string"},
Expand All @@ -3392,7 +3392,7 @@ def model_with_statements(context, **kwargs):
]
)

python_model = model.get_registry()["db.test_model"].model(
python_model = model.get_registry()["db.multi_engine_test_model"].model(
module_path=Path("."),
path=Path("."),
macros=macro.get_registry(),
Expand All @@ -3412,15 +3412,15 @@ def model_with_statements(context, **kwargs):
# Validate model-specific gateway usage during table creation
create_args = engine_adapters["secondary"].create_table.call_args_list
assert len(create_args) == 1
assert create_args[0][0] == (f"sqlmesh__db.db__test_model__{snapshot.version}",)
assert create_args[0][0] == (f"sqlmesh__db.db__multi_engine_test_model__{snapshot.version}",)

evaluator.promote([snapshot], EnvironmentNamingInfo(name="test_env"))

# Verify that the default gateway creates the view for the virtual layer
engine_adapters["secondary"].create_view.assert_not_called()
view_args = engine_adapters["default"].create_view.call_args_list
assert len(view_args) == 1
assert view_args[0][0][0] == "db__test_env.test_model"
assert view_args[0][0][0] == "db__test_env.multi_engine_test_model"

# For the pre/post statements verify the model-specific gateway was used
engine_adapters["default"].execute.assert_not_called()
Expand Down