Merged
Conversation
georgesittas
force-pushed
the
jo/deprecate_pydantic_v1
branch
from
346a7cb to
82779d4
Compare
eakmanrq
reviewed
Dec 20, 2024
georgesittas
force-pushed
the
jo/deprecate_pydantic_v1
branch
from
82779d4 to
9fb1d52
Compare
tobymao
approved these changes
Dec 20, 2024
georgesittas
force-pushed
the
jo/deprecate_pydantic_v1
branch
from
9fb1d52 to
97ab07e
Compare
Collaborator
|
FYI there are some comments saying we can deprecate code as a result of Pydantic 1 support being dropped. Here is one example: https://github.com/TobikoData/sqlmesh/blob/756eb705d0b4f33e8d2df9a2681f4678f312b9a6/sqlmesh/core/snapshot/definition.py#L428 I get though if you would prefer to not make a code change like this in the PR. |
Contributor
Author
Yep, I'm planning to clean all those sections up. There are several refactors that can happen after this deprecation. |
georgesittas
force-pushed
the
jo/deprecate_pydantic_v1
branch
from
97ab07e to
32724cd
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planning to refactor v1 artifacts in a followup PR.