Fix(clickhouse): specify DateTime64 precision for model partitioning expression#3582
Merged
Fix(clickhouse): specify DateTime64 precision for model partitioning expression#3582
Conversation
izeigerman
approved these changes
Jan 4, 2025
|
👍 only caveat I can see is that the maximum date representable in a DateTime64(9) is This only applies when you pass a non-conformable type like a string or an integer anyway, right? |
treysp
force-pushed
the
trey/fix-ch-dt64-prec
branch
from
a2aa0a3 to
d0e8400
Compare
Contributor
Author
Yep, if time column is non-conformable AND you don't include the time column in the model partitioning expression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLMesh automatically partitions Clickhouse incremental by time range models, aggregating timestamps to week. If the timestamp data type is not a datetime variant, SQLMesh automatically casts it to DateTime64 in the aggregation expression.
In Clickhouse, casting to DateTime64 type requires specifying a numeric precision.
This PR specifies a precision of 9/nanoseconds (using max precision to prevent accidental truncation of timestamp digits).