Fix: Unpaused snapshots that are downstream of snapshots with enabled auto-restatement can still be representative#3584
Merged
izeigerman merged 1 commit intomainfrom Jan 4, 2025
Conversation
… auto-restatement can still be representative
tobymao
approved these changes
Jan 4, 2025
izeigerman
deleted the
fix-auto-restatement-child-can-be-representative
branch
treysp
pushed a commit
to mesmith027/sqlmesh
that referenced
this pull request
Jan 7, 2025
… auto-restatement can still be representative (SQLMesh#3584)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that our deployability strategy for auto-restated models was a bit too aggressive. Snapshots that are downstream of snapshots with auto-restatement enabled were always classified as neither deployable nor representative.
However, if such a child is currently promoted in production, it can be perfectly suitable for reading in dev, assuming that the snapshot consuming this data remains non-deployable.