Fix: parse python model column types with dialect#3633
Merged
Conversation
treysp
changed the title
georgesittas
approved these changes
Jan 14, 2025
erindru
approved these changes
Jan 16, 2025
treysp
force-pushed
the
trey/py-model-dec-dialect
branch
from
c59f292 to
85145d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, python model column data types are parsed with the default sqlglot dialect instead of the explicit model dialect or project default dialect.
This PR updates it to use the explicit model dialect when present and default project dialect when not.