Merged
Conversation
eakmanrq
force-pushed
the
eakmanrq/move_double_escape_gen
branch
from
72ec394 to
756e281
Compare
Contributor
|
i don't know if this is right, let's chat about it |
eakmanrq
force-pushed
the
eakmanrq/move_double_escape_gen
branch
from
756e281 to
4a5b413
Compare
tobymao
reviewed
Feb 16, 2023
tobymao
reviewed
Feb 16, 2023
sqlmesh/core/engine_adapter/base.py
Outdated
Contributor
There was a problem hiding this comment.
exp.Literal.string(double_escape(e.name))
tobymao
approved these changes
Feb 16, 2023
eakmanrq
force-pushed
the
eakmanrq/move_double_escape_gen
branch
from
3c27b86 to
35e8eea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old implementation had us creating an engine adapter specific
to_jsonmethod for serializing Pydantic models to json. This had an issue with Airflow because it writes to Postgres. I decided that having this logic at the model serialization layer was to not the right place and easy to get wrong. I wanted to push it closer to sqlglot itself so I added it to where we override sqlglot behavior.