Skip to content

python models docs#382

Merged
tobymao merged 8 commits intomainfrom
toby/python_models
Feb 16, 2023
Merged

python models docs#382
tobymao merged 8 commits intomainfrom
toby/python_models

Conversation

@tobymao
Copy link
Contributor

@tobymao tobymao commented Feb 16, 2023

No description provided.

@tobymao tobymao requested review from a team and technically-tracy February 16, 2023 21:22
tobymao and others added 2 commits February 16, 2023 14:20
Co-authored-by: Iaroslav Zeigerman <zeigerman.ia@gmail.com>
Co-authored-by: Iaroslav Zeigerman <zeigerman.ia@gmail.com>
```


## Example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO the example is too overwhelming and contains a lot of unnecessary details. We need something more concise and simple.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll do this in a second pass

return pd.concat(dfs)
```

## Serialization
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this section really needed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want to add a gotchas section with serialization errors

tobymao and others added 4 commits February 16, 2023 14:40
Co-authored-by: Iaroslav Zeigerman <zeigerman.ia@gmail.com>
Co-authored-by: Iaroslav Zeigerman <zeigerman.ia@gmail.com>
Co-authored-by: Iaroslav Zeigerman <zeigerman.ia@gmail.com>
Co-authored-by: Iaroslav Zeigerman <zeigerman.ia@gmail.com>
@tobymao tobymao enabled auto-merge (squash) February 16, 2023 22:52
@tobymao tobymao merged commit 6f25368 into main Feb 16, 2023
@tobymao tobymao deleted the toby/python_models branch February 16, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants