fix: render signals properly for variables#3873
Merged
Conversation
tobymao
force-pushed
the
toby/signal_rendering
branch
2 times, most recently
from
274993f to
f64840a
Compare
tobymao
force-pushed
the
toby/signal_rendering
branch
3 times, most recently
from
0edbbc7 to
3b6565c
Compare
tobymao
force-pushed
the
toby/signal_rendering
branch
from
3b6565c to
89d9301
Compare
georgesittas
approved these changes
Feb 20, 2025
| k: seq_get(self._create_renderer(v).render() or [], 0) for k, v in kwargs.items() | ||
| } | ||
| for name, kwargs in self.signals | ||
| if name |
Contributor
There was a problem hiding this comment.
What's an example where name is falsey here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3869