perf: query tables with limit 0 when retrieving schema for tables wit…#3935
Merged
izeigerman merged 2 commits intoSQLMesh:mainfrom Mar 5, 2025
Merged
Conversation
|
|
Contributor
|
@lenare1K5 can you please sign the cla? |
Contributor
Author
|
@tobymao I signed the cla 👍 Should I also write some tests for my change? |
Contributor
There's already a test for this here: https://github.com/TobikoData/sqlmesh/blob/5ec13d29946b3903ae49de8bef650c0b37bac316/tests/core/engine_adapter/integration/test_integration_bigquery.py#L187 As long as you've verified that the |
georgesittas
approved these changes
Mar 5, 2025
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…h >3 identifiers