Merged
Conversation
sungchun12
commented
Mar 10, 2025
| ``` | ||
|
|
||
| SQLMesh will raise an error if the same rule is included in more than one of the `rules`, `warning_rules`, and `ignored_rules` keys since they should be mutually exclusive. No newline at end of file | ||
| SQLMesh will raise an error if the same rule is included in more than one of the `rules`, `warn_rules`, and `ignored_rules` keys since they should be mutually exclusive. No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
fixed this. warning_rules doesn't exist
sungchun12
commented
Mar 10, 2025
| @@ -1,5 +1,7 @@ | |||
| # Linter guide | |||
|
|
|||
|  | |||
Contributor
Author
There was a problem hiding this comment.
get people excited to see this image in their own terminal
treysp
approved these changes
Mar 11, 2025
Contributor
treysp
left a comment
treysp
left a comment
There was a problem hiding this comment.
Great improvements - thank you!
tests/core/test_context.py
Outdated
| def model3_entrypoint(evaluator: MacroEvaluator) -> str: | ||
| return "select * from model1" | ||
|
|
||
| # breakpoint() |
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a linting rule for a quick win like making sure audits are configured. This will serve as an example PR for others to contribute built-in rules that the community deems worthy for the masses.