Fix: determine SnapshotTableInfo equality with fingerprint only#3980
Merged
Fix: determine SnapshotTableInfo equality with fingerprint only#3980
Conversation
treysp
changed the title
izeigerman
approved these changes
Mar 12, 2025
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The view promotion logic determines what snapshots have been added based on equality between
SnapshotTableInfoobjects.In some cases, two snapshots' table infos may be functionally identical but have their parent node lists ordered differently. When this occurs, we incorrectly determine that they are not the same snapshot.
This PR overrides the
SnapshotTableInfo__eq__method to determine equality based solely on the snapshot fingerprint. All other similar comparisons in the code already use fingerprint.