Fix!: Type inference for BQ engine adapter#3981
Merged
Conversation
georgesittas
approved these changes
Mar 12, 2025
Contributor
georgesittas
left a comment
There was a problem hiding this comment.
LGTM, let's test these changes.
tobymao
approved these changes
Mar 12, 2025
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3978
In the BigQuery engine adapter, type inference for the fields happens through
to_standard_sql(); However, it seems like the types that do not belong to stanard SQL are not handled properly (e.g RANGE or JSON, see 4951ff9) and are instead marked asTYPE_KIND_UNSPECIFIED.This PR adds a fallback for these types and instead uses
field.field_type, as was used before: