Perf: use table name reference directly instead of select * subquery …#3991
Merged
tobymao merged 2 commits intoSQLMesh:mainfrom Mar 14, 2025
Merged
Conversation
Contributor
|
looks good, let's fix the build |
…in audit wo where
z3z1ma
force-pushed
the
perf/only-use-subq-in-audit-if-needed
branch
from
51c127b to
4d1ba03
Compare
Contributor
|
Looks like this change causes an unexpected metadata update. Probably because we use the rendered audit query to compute the metadata hash. @z3z1ma an empty migration script here https://github.com/TobikoData/sqlmesh/tree/main/sqlmesh/migrations will help the test pass |
Contributor
|
once i merge mine it’ll have a migration, so don’t worry about it |
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
#3991) Co-authored-by: Toby Mao <toby.mao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in audit wo where.
Striaghtforward change which allows audits without where conditions added by the snapshot containing a
time_columnto reference the table directly which reduces reliance on black box engine optimizer behavior.Resolves #3990