Merged
Conversation
5d10e44 to
d1fbbcf
Compare
tobymao
reviewed
Feb 19, 2023
| qualify_tables, | ||
| qualify_columns, | ||
| expand_laterals, | ||
| annotate_types, |
Contributor
There was a problem hiding this comment.
we need to do pushdown projections here instead
and keep annotate types outside in case it doesn’t work right
Contributor
Author
There was a problem hiding this comment.
Annotate types requires at least qualified columns to work properly, because it needs col.table not to be empty. I don't think it'll crash, since it just skips columns for which this isn't true:
for col in scope.columns: # line 282 in annotate_types.py
if not col.table:
continue
...However, if optimize does fail for some reason and we end up not having qualified columns, I'm not sure if it's worth running just annotate_types.
Contributor
Author
There was a problem hiding this comment.
I added pushdown projections.
tobymao
approved these changes
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #340