Fix: Enable schema binding when creating views for queries with recursive CTEs in redshift#4006
Merged
izeigerman merged 2 commits intomainfrom Mar 17, 2025
Merged
Conversation
…sive CTEs in redshift
erindru
approved these changes
Mar 17, 2025
izeigerman
force-pushed
the
fix-redhshift-schema-binding-for-recursive-ctes
branch
from
8b1d60a to
ee548a5
Compare
themisvaltinos
approved these changes
Mar 17, 2025
georgesittas
approved these changes
Mar 17, 2025
Comment on lines
+223
to
225
| has_recursive_cte = any( | ||
| w.args.get("recursive", False) for w in query_or_df.find_all(exp.With) | ||
| ) |
Contributor
There was a problem hiding this comment.
[Nit] I think you can do With.recursive and that gets you a bool directly.
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
…sive CTEs in redshift (#4006)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should always include NO SCHEMA BINDING when creating views in Redshift. Otherwise view creation fails when used with something like external tables.
At the same, views with NO SCHEMA BINDING can't be created for models that rely on recursive CTEs in their queries. This update makes it so that NO SCHEMA BINDING is omitted only when recursive CTES are used.