Skip to content

Fix: Only construct snapshot mapping once when computing missing intervals and the earliest start date #4012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
izeigerman merged 1 commit into from
Mar 18, 2025
Merged

Fix: Only construct snapshot mapping once when computing missing intervals and the earliest start date #4012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions sqlmesh/core/snapshot/definition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,11 +329,11 @@ class SnapshotInfoMixin(ModelKindMixin):
base_table_name_override: t.Optional[str]
dev_table_suffix: str

@property
@cached_property
def identifier(self) -> str:
return self.fingerprint.to_identifier()

@property
@cached_property
def snapshot_id(self) -> SnapshotId:
return SnapshotId(name=self.name, identifier=self.identifier)

Expand Down Expand Up @@ -1748,7 +1748,7 @@ def has_paused_forward_only(


def missing_intervals(
snapshots: t.Collection[Snapshot],
snapshots: t.Union[t.Collection[Snapshot], t.Dict[SnapshotId, Snapshot]],
start: t.Optional[TimeLike] = None,
end: t.Optional[TimeLike] = None,
execution_time: t.Optional[TimeLike] = None,
Expand All @@ -1759,6 +1759,9 @@ def missing_intervals(
end_bounded: bool = False,
) -> t.Dict[Snapshot, Intervals]:
"""Returns all missing intervals given a collection of snapshots."""
if not isinstance(snapshots, dict):
# Make sure that the mapping is only constructed once
snapshots = {snapshot.snapshot_id: snapshot for snapshot in snapshots}
missing = {}
cache: t.Dict[str, datetime] = {}
end_date = end or now_timestamp()
Expand All @@ -1771,7 +1774,7 @@ def missing_intervals(
interval_end_per_model = interval_end_per_model or {}
deployability_index = deployability_index or DeployabilityIndex.all_deployable()

for snapshot in snapshots:
for snapshot in snapshots.values():
if not snapshot.evaluatable:
continue
snapshot_start_date = start_dt
Expand Down Expand Up @@ -1944,7 +1947,7 @@ def inclusive_exclusive(


def earliest_start_date(
snapshots: t.Collection[Snapshot],
snapshots: t.Union[t.Collection[Snapshot], t.Dict[SnapshotId, Snapshot]],
cache: t.Optional[t.Dict[str, datetime]] = None,
relative_to: t.Optional[TimeLike] = None,
) -> datetime:
Expand All @@ -1959,9 +1962,12 @@ def earliest_start_date(
"""
cache = {} if cache is None else cache
if snapshots:
if not isinstance(snapshots, dict):
# Make sure that the mapping is only constructed once
snapshots = {snapshot.snapshot_id: snapshot for snapshot in snapshots}
return min(
start_date(snapshot, snapshots, cache=cache, relative_to=relative_to)
for snapshot in snapshots
for snapshot in snapshots.values()
)
return yesterday()

Expand Down