Fix: Always support start_* / end_* macros in pre- / post- statements#4025
Merged
izeigerman merged 1 commit intomainfrom Mar 25, 2025
Merged
Fix: Always support start_* / end_* macros in pre- / post- statements#4025izeigerman merged 1 commit intomainfrom
izeigerman merged 1 commit intomainfrom
Conversation
izeigerman
force-pushed
the
fix-support-start-end-in-pre-post
branch
from
e187bca to
b0a6e80
Compare
tobymao
approved these changes
Mar 25, 2025
Contributor
tobymao
left a comment
tobymao
left a comment
There was a problem hiding this comment.
why do this make sense in pre and post statements?
Contributor
Author
|
@tobymao side effects like measurement recording, reporting, etc. |
izeigerman
force-pushed
the
fix-support-start-end-in-pre-post
branch
from
b0a6e80 to
b1b383f
Compare
izeigerman
force-pushed
the
fix-support-start-end-in-pre-post
branch
from
b1b383f to
1d58fb6
Compare
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, whether the
start_*/end_*macros were supported in pre- or post-statements depended on the model kind. For example, they were not supported if the model was of kind VIEW or FULL. This change ensures that these macros are always available in pre- and post-statements