Fix!: Move linting from load to plan creation#4032
Merged
Conversation
VaggelisD
force-pushed
the
vaggelisd/lint_plan_time
branch
from
94f823e to
4761a85
Compare
Contributor
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Imo it makes sense to add a --skip-lints flag to the plan command, similar to --skip-tests, because you may just wanna iterate in dev and not have the linter yell at you.
LGTM, otherwise 👍
Contributor
Author
Added it in the latest commit |
georgesittas
approved these changes
Mar 26, 2025
izeigerman
reviewed
Mar 26, 2025
izeigerman
approved these changes
Mar 26, 2025
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, linting happens during load time which has proven to cause the following issues:
sqlmesh infowhich don't always warrant lintingsqlmesh lintcommand, since theContextis already loaded (and linted) before the CLI command has been registeredLinterErroris raised the CI/CD bot does not have the full output.This PR moves the linting process to plan time which solves the aforementioned issues.