Feat!: Make model tests run concurrently#4047
Merged
Conversation
izeigerman
reviewed
Mar 28, 2025
izeigerman
reviewed
Mar 31, 2025
izeigerman
reviewed
Mar 31, 2025
izeigerman
reviewed
Mar 31, 2025
izeigerman
reviewed
Mar 31, 2025
izeigerman
approved these changes
Mar 31, 2025
Contributor
izeigerman
left a comment
izeigerman
left a comment
There was a problem hiding this comment.
A few comments to consider, looks good otherwise
georgesittas
reviewed
Apr 1, 2025
georgesittas
reviewed
Apr 2, 2025
VaggelisD
force-pushed
the
vaggelisd/concurrent_tests
branch
from
669e236 to
3116186
Compare
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, model tests run sequentially leveraging the
unittestframework. This PR adds concurrency to further speed up the testing process by splitting the work between threads, each of whom runs a single test. Then, the results are aggregated into one and shown back to the user.For this process, some of the internals of the
TestTextRunnerare borrowed in order to generate the final report; This is because we now have N runners which would output a full report for each test.