fix!: fix macros with spaces to make them more consistent#4052
Merged
Conversation
izeigerman
approved these changes
Mar 30, 2025
georgesittas
approved these changes
Mar 31, 2025
Comment on lines
+1103
to
+1093
| evaluator.evaluate(d.parse_one(""" @DEF(x, "a b") """)) | ||
| evaluator.evaluate(d.parse_one(""" @DEF(y, 'a b') """)) | ||
| evaluator.evaluate(d.parse_one(""" @DEF(z, a."b c") """)) | ||
|
|
||
| for sql, expected in ( |
Contributor
There was a problem hiding this comment.
Consider testing with config variables as well besides @DEF ones. For example:
# config.yaml
variables:
v1: "a b"
v2: '"a b"'
v3: "'a b'"
Contributor
Author
There was a problem hiding this comment.
i'm not sure if config variables iare in the scope of these tests, that's probably something to go with your changes
this could break existing macro usage with variables that have spaces
tobymao
force-pushed
the
toby/macros_with_spaces
branch
from
deb9277 to
114bb9b
Compare
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this could break existing macro usage with variables that have spaces