Fix: Account for array types when showing sample in table diff#4077
Merged
themisvaltinos merged 4 commits intomainfrom Apr 3, 2025
Merged
Fix: Account for array types when showing sample in table diff#4077themisvaltinos merged 4 commits intomainfrom
themisvaltinos merged 4 commits intomainfrom
Conversation
izeigerman
reviewed
Apr 3, 2025
izeigerman
approved these changes
Apr 3, 2025
georgesittas
reviewed
Apr 3, 2025
Contributor
Author
|
Thanks for the review addressed comments |
georgesittas
reviewed
Apr 3, 2025
georgesittas
approved these changes
Apr 3, 2025
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update improves the filtering approach in table diff when displaying the diff samples for a column, which failed to properly handle array types before.
As part of this also decimal values are now correctly aligned by propagating the decimal precision in row diff to properly display them in the sample. Also added helper methods (
capture_console_outputandcreate_test_console) so we can verify in tests the exact output of console methods from now on.