Docs: Trey edits to hybrid deployment docs#4122
Merged
tobymao merged 3 commits intoeakmanrq/add_helm_and_docker_compose_hybridfrom Apr 11, 2025
Merged
Docs: Trey edits to hybrid deployment docs#4122tobymao merged 3 commits intoeakmanrq/add_helm_and_docker_compose_hybridfrom
tobymao merged 3 commits intoeakmanrq/add_helm_and_docker_compose_hybridfrom
Conversation
treysp
force-pushed
the
trey/hybrid-deploy-docs-edits
branch
from
f46519b to
4196658
Compare
treysp
force-pushed
the
trey/hybrid-deploy-docs-edits
branch
from
4196658 to
82bd630
Compare
eakmanrq
reviewed
Apr 10, 2025
docs/cloud/features/scheduler/hybrid_executors/hybrid-executors_standard-hybrid-deployment.png
Show resolved
Hide resolved
eakmanrq
reviewed
Apr 10, 2025
eakmanrq
reviewed
Apr 10, 2025
eakmanrq
reviewed
Apr 10, 2025
Collaborator
eakmanrq
left a comment
eakmanrq
left a comment
There was a problem hiding this comment.
One thing that would be nice to mention, that I wasn't sure where to fit it in, is that in the Helm deployment the chart will configure all the environment variables for them automatically. They just need to fill out the values.yaml. This is what we want users doing if they are doing a k8s deployment since it means it will be done correctly. So it would be great if we had something that pushed them over to the helm docs rather then reading this and thinking they can configure it themselves. Also if they are thinking they won't be deploying with helm that is fine they can still use it to generate the correct environment variables.
tobymao
merged commit 7cca1ff
into
eakmanrq/add_helm_and_docker_compose_hybrid
19 checks passed
treysp
added a commit
that referenced
this pull request
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.