Fix: Avoid concurrent dialect patching in model testing#4266
Merged
Conversation
izeigerman
reviewed
Apr 28, 2025
izeigerman
reviewed
Apr 28, 2025
19e24a3 to
deca19c
Compare
izeigerman
reviewed
Apr 30, 2025
izeigerman
approved these changes
Apr 30, 2025
izeigerman
reviewed
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To freeze time through
execution_timein unit tests we essentially patch the SQLGlot dialects globally to generate anyCURRENT_<date/time>()reference as a cast at the specified time & type.This works fine if tests are run sequentially but runs into race conditions in concurrent execution. This PR:
Replaces the global patching for SQL models by instead transforming the corresponding AST nodes before generation
Locks the global patching for Python models using the runner's
lock; This is required because Python models can execute any SQL statement, so the patching is indeed necessary to cover that globally.