Fix: use MarkdownConsole in non-interactive contexts#4306
Merged
Conversation
4ac14f7 to
f5a3725
Compare
izeigerman
reviewed
May 2, 2025
615046e to
a9685ba
Compare
a9685ba to
1deb3f6
Compare
izeigerman
reviewed
May 7, 2025
izeigerman
reviewed
May 7, 2025
izeigerman
reviewed
May 7, 2025
izeigerman
reviewed
May 7, 2025
9861b6b to
9745d22
Compare
izeigerman
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some terminals do not support unicode emoji like those used in the standard CLI output (e.g., running SQLMesh with Powershell.exe in Github Actions). Using the
MarkdownConsoleinstead of standardTerminalConsoleaddresses this problem.There is not a universal way to determine whether a given terminal supports Unicode, so we instead assume that unicode is not needed in any non-interactive context (typically a CI platform).
This PR:
MarkdownConsoleif soSQLMESH_RUNTIME_ENVIRONMENTenv varterminal,databricks,google_colab,jupyter,debugger,non_interactive,ci