Chore: do not warn if non-literal is used in then/else_value of PIVOT macro#4423
Merged
georgesittas merged 2 commits intomainfrom May 16, 2025
Merged
Chore: do not warn if non-literal is used in then/else_value of PIVOT macro#4423georgesittas merged 2 commits intomainfrom
georgesittas merged 2 commits intomainfrom
Conversation
izeigerman
reviewed
May 15, 2025
georgesittas
force-pushed
the
jo/fix_pivot_coercion_warning
branch
from
e80ed91 to
4629541
Compare
georgesittas
commented
May 15, 2025
Comment on lines
+1090
to
+1100
| column: SQL, | ||
| values: t.List[SQL], | ||
| alias: bool = True, | ||
| agg: SQL = SQL("SUM"), | ||
| cmp: SQL = SQL("="), | ||
| prefix: SQL = SQL(""), | ||
| suffix: SQL = SQL(""), | ||
| then_value: SQL = SQL("1"), | ||
| else_value: SQL = SQL("0"), | ||
| quote: bool = True, | ||
| distinct: bool = False, |
Contributor
Author
alex-harness
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4421