[DBT] Add support for the 'exceptions' jinja namespace#463
Merged
georgesittas merged 3 commits intomainfrom Mar 1, 2023
Merged
[DBT] Add support for the 'exceptions' jinja namespace#463georgesittas merged 3 commits intomainfrom
georgesittas merged 3 commits intomainfrom
Conversation
georgesittas
commented
Mar 1, 2023
crericha
reviewed
Mar 1, 2023
sqlmesh/dbt/builtin.py
Outdated
Contributor
There was a problem hiding this comment.
Did you look at the dbt implementation? Does it only print out the message or does it prepend something?
Contributor
Author
There was a problem hiding this comment.
The dbt implementation uses a python logger:
https://github.com/dbt-labs/dbt-core/blob/dev/octavius-catto/core/dbt/exceptions.py#LL925
With the changes introduced in your refactor, we can probably use python loggers too now, both here and for log.
Contributor
Author
There was a problem hiding this comment.
We can use print for the time being, and I can improve both this and log by adding support for python logging.
georgesittas
force-pushed
the
jo/dbt_exceptions
branch
from
e0843de to
1c9a8cb
Compare
georgesittas
force-pushed
the
jo/dbt_exceptions
branch
from
1c9a8cb to
ec9de85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.getdbt.com/reference/dbt-jinja-functions/exceptions