Skip to content

Add support for private Jinja macros to the JinjamMacroRegistry#480

Merged
izeigerman merged 1 commit intomainfrom
handle-private-macro-names
Mar 4, 2023
Merged

Add support for private Jinja macros to the JinjamMacroRegistry#480
izeigerman merged 1 commit intomainfrom
handle-private-macro-names

Conversation

@izeigerman
Copy link
Contributor

This is to support "private" macro definitions which are used in dbt_utils. The fix was necessary due to:

If a macro name starts with an underscore, it’s not exported and can’t be imported.

https://jinja.palletsprojects.com/en/3.1.x/templates/#macros

@izeigerman izeigerman requested review from a team, crericha and tobymao March 3, 2023 19:34
@izeigerman izeigerman force-pushed the handle-private-macro-names branch from 8385bb5 to 1a28456 Compare March 3, 2023 23:54
@izeigerman izeigerman force-pushed the handle-private-macro-names branch from 1a28456 to 6e925f4 Compare March 3, 2023 23:54
@izeigerman izeigerman enabled auto-merge (squash) March 4, 2023 00:21
@izeigerman izeigerman disabled auto-merge March 4, 2023 00:21
@izeigerman izeigerman merged commit 18b7754 into main Mar 4, 2023
@izeigerman izeigerman deleted the handle-private-macro-names branch March 4, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants