Chore!: Update ci/cd bot default behaviour to match CLI behaviour#4900
Merged
Chore!: Update ci/cd bot default behaviour to match CLI behaviour#4900
Conversation
erindru
commented
Jul 4, 2025
| def _inherit_project_config_in_cicd_bot(self) -> Self: | ||
| if self.cicd_bot: | ||
| # inherit the project-level settings into the CICD bot if they have not been explicitly overridden | ||
| if self.cicd_bot.auto_categorize_changes_ is None: |
Collaborator
Author
There was a problem hiding this comment.
The documentation claimed that these properties defaulted to the project's config value, however that wasn't working.
This Pydantic validator ensures that the project config is copied down to the bot config if the bot config has not set these fields already.
It needs to happen here because the bot config does not have a reference to the project config to look up these values afterwards
6e2512c to
9cbbfe8
Compare
georgesittas
approved these changes
Jul 7, 2025
3097707 to
a4167e6
Compare
a4167e6 to
85400d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the CI/CD bot to partial parity with the CLI in terms of default behaviour, with a path to full parity in future.
Prior to this, by default the CI/CD bot would:
This is in contrast to the CLI, which, when running a command like
sqlmesh plan pr_envresults in a much more streamlined experience as it:prodcan be a virtual updateThis PR takes one step towards treating the bot like an automated extension of the CLI.
Internal analytics showed that 97% of users were already overriding
auto_categorize_changesfrom the default, so this PR updates the default to be inline with what the documentation was suggesting and inherit the project behaviour (auto-categorize all changes).However, internal analytics also showed that close to 33% of users were either leaving
skip_pr_backfillat the default oftrueor not setting it at all.Rather than break these workflows straight away, if
skip_pr_backfillis not explicitly set, SQLMesh will produce a warning like so:To remove the warning, explicitly set
skip_pr_backfillto the desired value.In a future release, we will update the default value to match the CLI after everyone has had a chance to update their config.