Conversation
sqlmesh/core/engine_adapter/base.py
Outdated
There was a problem hiding this comment.
Is there a reason properties are required? Does it make more sense to leave as is and in exp.update do properties or {}?
There was a problem hiding this comment.
I think "properties" are required in the SQL UPDATE clause, right?
There was a problem hiding this comment.
I mean does update_table need to require them or can we keep as None and use an empty hash for update in that case.
There was a problem hiding this comment.
Since update_table represents the execution of an UPDATE clause, I think it's logical to require them. I can't think of or find a counterexample in our codebase where it needs to have this flexibility.
There was a problem hiding this comment.
Okay. I wonder why it was like that in the first place then.
georgesittas
force-pushed
the
jo/fix_mypy
branch
from
54f2658 to
e3eb3e9
Compare
3 participants
Addressed mypy issues caused by recent SQLGlot commit