fix: use distinct names for input views when testing models#537
Merged
izeigerman merged 1 commit intomainfrom Mar 15, 2023
Merged
fix: use distinct names for input views when testing models#537izeigerman merged 1 commit intomainfrom
izeigerman merged 1 commit intomainfrom
Conversation
tobymao
reviewed
Mar 15, 2023
| mapping = {name: name for name in snapshots} | ||
| mapping = {name: _test_fixture_name(name) for name in snapshots} | ||
| if mapping: | ||
| self.query = exp.replace_tables(self.query, mapping) |
Contributor
There was a problem hiding this comment.
isn't this blindly replacing every table? isn't that problematic as we discussed?
Contributor
Author
There was a problem hiding this comment.
No, since tables are prefixed with a schema name and CTEs are not.
tobymao
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.