fix: ignore cluster_by config for embedded model kind#5409
Merged
Conversation
themisvaltinos
approved these changes
Sep 18, 2025
Contributor
themisvaltinos
left a comment
themisvaltinos
left a comment
There was a problem hiding this comment.
lgtm! one nit though not important. and thinking in the warning message referring to it as ephemeral rather than embedded to avoid confusion for the dbt users, though should be fine either way
sqlmesh/dbt/model.py
Outdated
| "Ignoring cluster_by config for model '%s'; cluster_by is not supported for views.", | ||
| self.name, | ||
| ) | ||
| elif isinstance(kind, EmbeddedKind): |
Contributor
There was a problem hiding this comment.
nit: maybe combine with above to avoid code duplication. so something like:
if isinstance(kind, (ViewKind, EmbeddedKind)):
logger.warning(
"Ignoring cluster_by config for model '%s'; cluster_by is not supported for %s.",
self.name,
"views" if isinstance(kind, ViewKind) else "embedded models",
)
Contributor
Author
There was a problem hiding this comment.
will update with this fix + changing warning message to ephemeral. thanks for catching!
toriwei
force-pushed
the
tori/fix-modelconfig-clusterby-embedded
branch
from
4d793f8 to
5b68949
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbt ignores cluster_by for ephemeral materializations, updating to match that behavior.