Fix: Do not modify updated_ts when unpausing all snapshots with target name#5766
Merged
Fix: Do not modify updated_ts when unpausing all snapshots with target name#5766
Conversation
…t name Signed-off-by: Chris Rericha <chris@tobikodata.com>
crericha
force-pushed
the
fix-snapshot-unpause
branch
from
21ae282 to
b5e3049
Compare
izeigerman
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #5147 introduced an optimization to snapshot unpausing logic. Part of the logic unset the
unpaused_tsfor all snapshots will the same name as a promoted snapshots and also set theirupdated_tsto now. The latter had a side effect of having old snapshots appear newer than they actually were and skip garbage collection by the janitor.The fix is to not set
updated_ts.Test Plan
The change is trivial and the original PR did not introduce any tests for the behavior, so not test to update either.
Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO