[UI] Fix virtual update not applied and rename 'logical' to 'virtual'#579
Merged
[UI] Fix virtual update not applied and rename 'logical' to 'virtual'#579
Conversation
eakmanrq
approved these changes
Mar 22, 2023
| 'All changes and their downstream dependencies can be fully previewed before they get promoted. If during plan creation no data gaps have been detected and only references to new model versions need to be updated, then such update is referred to as logical. Logical updates impose no additional runtime overhead or cost.', | ||
| hasVirtualUpdate: false, | ||
| virtualUpdateDescription: | ||
| 'All changes and their downstream dependencies can be fully previewed before they get promoted. If during plan creation no data gaps have been detected and only references to new model versions need to be updated, then such update is referred to as Virtual. Virtual updates impose no additional runtime overhead or cost.', |
Contributor
There was a problem hiding this comment.
then such update is referred to as Virtual Update. Virtual Updates
The feature is "Virtual Update" and I always uppercase the update.
vchan
approved these changes
Mar 22, 2023
| ) | ||
|
|
||
| const hasLogicalUpdate = hasChanges && isFalse(hasBackfills) | ||
| // const hasVirtualUpdate = hasChanges && isFalse(hasBackfills) |
Contributor
There was a problem hiding this comment.
Suggested change
| // const hasVirtualUpdate = hasChanges && isFalse(hasBackfills) |
| 'All changes and their downstream dependencies can be fully previewed before they get promoted. If during plan creation no data gaps have been detected and only references to new model versions need to be updated, then such update is referred to as logical. Logical updates impose no additional runtime overhead or cost.', | ||
| hasVirtualUpdate: false, | ||
| virtualUpdateDescription: | ||
| 'All changes and their downstream dependencies can be fully previewed before they get promoted. If during plan creation no data gaps have been detected and only references to new model versions need to be updated, then such update is referred to as Virtual Update. Virtual Updates impose no additional runtime overhead or cost.', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'All changes and their downstream dependencies can be fully previewed before they get promoted. If during plan creation no data gaps have been detected and only references to new model versions need to be updated, then such update is referred to as Virtual Update. Virtual Updates impose no additional runtime overhead or cost.', | |
| 'All changes and their downstream dependencies can be fully previewed before they get promoted. If during plan creation no data gaps have been detected and only references to new model versions need to be updated, then such an update is referred to as a Virtual Update. Virtual Updates impose no additional runtime overhead or cost.', |
web/server/api/endpoints/commands.py
Outdated
| await request.app.state.task | ||
|
|
||
| return models.ApplyResponse(type="backfill" if plan.requires_backfill else "logical") | ||
| return models.ApplyResponse(type="backfill" if plan.requires_backfill else "virtual") |
Contributor
There was a problem hiding this comment.
Let's use the ApplyType enum here.
vchan
reviewed
Mar 22, 2023
Co-authored-by: Vincent Chan <vchan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.