Merged
Conversation
tobymao
force-pushed
the
toby/multi
branch
14 times, most recently
from
db40cdc to
96ac3e3
Compare
izeigerman
reviewed
Apr 17, 2023
izeigerman
reviewed
Apr 17, 2023
izeigerman
reviewed
Apr 17, 2023
izeigerman
reviewed
Apr 17, 2023
tobymao
force-pushed
the
toby/multi
branch
4 times, most recently
from
3db7e8e to
9b2b26c
Compare
izeigerman
reviewed
Apr 17, 2023
sqlmesh/core/context.py
Outdated
Contributor
There was a problem hiding this comment.
The reason I introduced local_snapshots is to not require connection to the state sync (eg. when running unit tests) as part of #507. Any chance we can somehow move this logic into def snapshots and have an optional external_snapshots argument or something?
tobymao
force-pushed
the
toby/multi
branch
3 times, most recently
from
ab4fb19 to
9b23169
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.